What kind of response might a super-reviewer give?
Some typical responses include: • Give an “sr=[name].” • Give an “r/sr=[name].” This is possible when the SR is also designated as a reviewer for the affected area. This response means that the approval can be used as either the review or the super-review (but not both). This gives the patch author a larger pool of people from whom the second review can be received. • Request changes and re-submission of updated patch. • Request changes and note something like “once changes made, sr=[name].” • Give an “rs=[name].” This means that the super-reviewer believes the patch is small or obvious enough that a super-review is not needed. • Ask that the module owner complete that review first. • Ask someone to apply the patch first and test it (often a good teaching device). • Ask another super-reviewer to take the patch. • Ask for clarification, or a risk analysis. Super-reviewers may make suggestions not on this list. We hope they do, we certainly don’t have all the answers today.
